add crane agent , int crane agent it contained the node-qos-ensurance-policy-controller #5
Conversation
yan234280533
force-pushed
the
dev-ensurance-2-crane-agent
branch
12 times, most recently
from
f103c04
to
946dbce
Compare
pkg/ensurance/opamock/opamock.go
Outdated
| @@ -0,0 +1,12 @@ | |||
| package opamock | |||
|
|
|||
| func OpaEval(metricName string, targetValue float64, value float64) (bool, error) { | |||
There was a problem hiding this comment.
Here the function interface should be something like Eval(ctx, input).
metricName, targetValue... all these kind of things should not be placed here.
There was a problem hiding this comment.
type Logic interface {
EvalWithMetric(metricName string, targetValue float64, value float64) (bool, error)
EvalWithRaw(input string, rule string) (bool, error)
}
I modified it like this, please have a look it feasible now ?
deploy/deploy/crane-agent/rbac.yaml
Outdated
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - podqosensurancepolicies.ensurance.crane.io |
There was a problem hiding this comment.
Can we design a more general thing replacing podqosensurancepolicies & nodeqosensurancepolicies?
yan234280533
force-pushed
the
dev-ensurance-2-crane-agent
branch
10 times, most recently
from
bc4c244
to
cf69220
Compare
yan234280533
force-pushed
the
dev-ensurance-2-crane-agent
branch
10 times, most recently
from
398698e
to
693fed1
Compare
yan234280533
force-pushed
the
dev-ensurance-2-crane-agent
branch
from
693fed1
to
618c625
Compare
cmd/crane-agent/app/manager.go
Outdated
|
|
||
| // Run runs the crane-agent with options. This should never exit. | ||
| func Run(ctx context.Context, opts *options.Options) error { | ||
| mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{ |
There was a problem hiding this comment.
Please remove all controller-runtime related codes since we don't use it in agent
| import ( | ||
| v1 "k8s.io/api/core/v1" | ||
|
|
||
| einformer "github.com/gocrane/crane/pkg/ensurance/informer" |
|
|
||
| // Run starts k8s informers | ||
| func (c *Context) Run() { | ||
| if c.podFactory != nil { |
There was a problem hiding this comment.
missing the check for start error and WaitForCacheSync error?
| @@ -0,0 +1,208 @@ | |||
| package runtime | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
Since this pr is only about NodeQoS implement, these runtime and container codes can submit later?
yan234280533
force-pushed
the
dev-ensurance-2-crane-agent
branch
6 times, most recently
from
de24dde
to
b3318f8
Compare
yan234280533
force-pushed
the
dev-ensurance-2-crane-agent
branch
2 times, most recently
from
c3d8143
to
a686700
Compare
|
/lgtm |
to instead pr#4 which is lost associated