Add extend memory in nodeResourceManager #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chenkaiyue
commented
Sep 1, 2022
•
chenkaiyue
commented
- Add extend memory in nodeResourceManager
- Don't exit when there is no node tsp
- Collect memory info for pod and container
- Fix cadvisor can't get container info error
|
|
mfanjie
reviewed
Sep 1, 2022
pkg/agent/agent.go
Outdated
| if err != nil { | ||
| return agent, err | ||
| } | ||
| tspName, _ := agent.CreateNodeResourceTsp() |
There was a problem hiding this comment.
If we can't creat node tsp, the program should go on, there is local data after all.
| @@ -212,14 +219,19 @@ func (o *NodeResourceManager) BuildNodeStatus(node *v1.Node) map[string]int64 { | |||
| var nextRecommendation float64 | |||
| switch resourceName { | |||
| case v1.ResourceCPU: | |||
| if reserveCpuPercent != nil { | |||
| if *reserveCpuPercent != 0 { | |||
There was a problem hiding this comment.
nil check for reserveCpuPercent, or the program will crash with nil error
There was a problem hiding this comment.
The construction process of reserveCpuPercent make reserveCpuPercent will not be nil.
|
🎉 Successfully Build Images. Docker RegistryOverview: https://hub.docker.com/u/gocrane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=gocrane/craned \
--set craned.image.tag=pr-541-20e5bd8 \
--set metricAdapter.image.repository=gocrane/metric-adapter \
--set metricAdapter.image.tag=pr-541-20e5bd8 \
--set craneAgent.image.repository=gocrane/crane-agent \
--set craneAgent.image.tag=pr-541-20e5bd8 \
--set cranedDashboard.image.repository=gocrane/dashboard \
--set cranedDashboard.image.tag=pr-541-20e5bd8 crane/craneCoding RegistryOverview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
--set craned.image.tag=pr-541-20e5bd8 \
--set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-541-20e5bd8 \
--set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-541-20e5bd8 \
--set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-541-20e5bd8 crane/craneGhcr RegistryOverview: https://github.com/orgs/gocrane/packages?repo_name=crane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=ghcr.io/gocrane/crane/craned \
--set craned.image.tag=pr-541-20e5bd8 \
--set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-541-20e5bd8 \
--set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-541-20e5bd8 \
--set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-541-20e5bd8 crane/crane |
chenkaiyue
force-pushed
the
extend-memory
branch
3 times, most recently
from
0489097
to
f662738
Compare
…and container;Fix cadvisor can't get container info err
chenkaiyue
force-pushed
the
extend-memory
branch
from
f662738
to
20e5bd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.