Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typo in evpa and remove useless variable #553

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

whitebear009
Copy link
Contributor

What type of PR is this?

optimize

What this PR does / why we need it:

fix some typo in evpa and remove useless variable

Which issue(s) this PR fixes:

Special notes for your reviewer:

@github-actions
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-09-15 12:30
Git Version: 881f7f0

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-553-881f7f0 docker pull gocrane/crane-agent:pr-553-881f7f0
dashboard:pr-553-881f7f0 docker pull gocrane/dashboard:pr-553-881f7f0
metric-adapter:pr-553-881f7f0 docker pull gocrane/metric-adapter:pr-553-881f7f0
craned:pr-553-881f7f0 docker pull gocrane/craned:pr-553-881f7f0

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-553-881f7f0 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-553-881f7f0 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-553-881f7f0 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-553-881f7f0 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-553-881f7f0 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-553-881f7f0
dashboard:pr-553-881f7f0 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-553-881f7f0
metric-adapter:pr-553-881f7f0 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-553-881f7f0
craned:pr-553-881f7f0 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-553-881f7f0

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-553-881f7f0 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-553-881f7f0 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-553-881f7f0 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-553-881f7f0 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-553-881f7f0 docker pull ghcr.io/gocrane/crane/crane-agent:pr-553-881f7f0
dashboard:pr-553-881f7f0 docker pull ghcr.io/gocrane/crane/dashboard:pr-553-881f7f0
metric-adapter:pr-553-881f7f0 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-553-881f7f0
craned:pr-553-881f7f0 docker pull ghcr.io/gocrane/crane/craned:pr-553-881f7f0

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-553-881f7f0 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-553-881f7f0 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-553-881f7f0 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-553-881f7f0 crane/crane

Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@qmhu qmhu merged commit da41134 into gocrane:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants