Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prediction without resource metrics #568

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Conversation

saikey0379
Copy link
Contributor

What type of PR is this?

Bug of IsEHPAHasPredictionMetric

What this PR does / why we need it:

fix prediction without resource metrics

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@github-actions
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2022-09-26 11:16
Git Version: 6f7220f

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-568-6f7220f docker pull gocrane/crane-agent:pr-568-6f7220f
dashboard:pr-568-6f7220f docker pull gocrane/dashboard:pr-568-6f7220f
metric-adapter:pr-568-6f7220f docker pull gocrane/metric-adapter:pr-568-6f7220f
craned:pr-568-6f7220f docker pull gocrane/craned:pr-568-6f7220f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-568-6f7220f \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-568-6f7220f \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-568-6f7220f \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-568-6f7220f crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-568-6f7220f docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-568-6f7220f
dashboard:pr-568-6f7220f docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-568-6f7220f
metric-adapter:pr-568-6f7220f docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-568-6f7220f
craned:pr-568-6f7220f docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-568-6f7220f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-568-6f7220f \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-568-6f7220f \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-568-6f7220f \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-568-6f7220f crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-568-6f7220f docker pull ghcr.io/gocrane/crane/crane-agent:pr-568-6f7220f
dashboard:pr-568-6f7220f docker pull ghcr.io/gocrane/crane/dashboard:pr-568-6f7220f
metric-adapter:pr-568-6f7220f docker pull ghcr.io/gocrane/crane/metric-adapter:pr-568-6f7220f
craned:pr-568-6f7220f docker pull ghcr.io/gocrane/crane/craned:pr-568-6f7220f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-568-6f7220f \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-568-6f7220f \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-568-6f7220f \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-568-6f7220f crane/crane

@qmhu qmhu merged commit cc7109e into gocrane:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants