add cpumanager #574
Merged
add cpumanager #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garrybest
force-pushed
the
pr_cpumanager
branch
2 times, most recently
from
d6b622a
to
6494733
Compare
|
🎉 Successfully Build Images. Docker RegistryOverview: https://hub.docker.com/u/gocrane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=gocrane/craned \
--set craned.image.tag=pr-574-75d51c0 \
--set metricAdapter.image.repository=gocrane/metric-adapter \
--set metricAdapter.image.tag=pr-574-75d51c0 \
--set craneAgent.image.repository=gocrane/crane-agent \
--set craneAgent.image.tag=pr-574-75d51c0 \
--set cranedDashboard.image.repository=gocrane/dashboard \
--set cranedDashboard.image.tag=pr-574-75d51c0 crane/craneCoding RegistryOverview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
--set craned.image.tag=pr-574-75d51c0 \
--set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-574-75d51c0 \
--set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-574-75d51c0 \
--set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-574-75d51c0 crane/craneGhcr RegistryOverview: https://github.com/orgs/gocrane/packages?repo_name=crane
Quick Deploy - Helm helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=ghcr.io/gocrane/crane/craned \
--set craned.image.tag=pr-574-75d51c0 \
--set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-574-75d51c0 \
--set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-574-75d51c0 \
--set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-574-75d51c0 crane/crane |
Garrybest
force-pushed
the
pr_cpumanager
branch
4 times, most recently
from
029908b
to
4a3346a
Compare
Signed-off-by: Garrybest <garrybest@foxmail.com>
Garrybest
force-pushed
the
pr_cpumanager
branch
from
4a3346a
to
186cbcf
Compare
mfanjie
reviewed
Oct 9, 2022
| if err := agent.CreateNodeResourceTopology(sysPath); err != nil { | ||
| return nil, err | ||
| } | ||
| if utilfeature.DefaultFeatureGate.Enabled(features.CraneCPUManager) { |
There was a problem hiding this comment.
is there a case that we enable nrt only but do not enable cpumanager? if not, should we have a single feature gate?
There was a problem hiding this comment.
Yes, in that case only nrt is collected, cpumanager does nothing to allocate cpuset. So they are different.
Signed-off-by: Garrybest <garrybest@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Garrybest garrybest@foxmail.com
What type of PR is this?
Add cpumanager.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: