Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update manifests #655

Merged
merged 1 commit into from
Dec 19, 2022
Merged

update manifests #655

merged 1 commit into from
Dec 19, 2022

Conversation

lbbniu
Copy link
Member

@lbbniu lbbniu commented Dec 15, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #615

Special notes for your reviewer:

@chenkaiyue
Copy link
Contributor

chenkaiyue commented Dec 16, 2022 •
edited
Loading

Can you help combine the two "update deploy" commits? @lbbniu

qmhu
qmhu reviewed Dec 16, 2022
View reviewed changes
Copy link
Member

@qmhu qmhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove these deprecated crd:

deploy/manifests/prediction.crane.io_nodepredictions.yaml
deploy/manifests/prediction.crane.io_podgrouppredictions.yaml

@qmhu qmhu merged commit b75117c into gocrane:main Dec 19, 2022
@lbbniu lbbniu deleted the fix/crd branch May 8, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmhu qmhu qmhu approved these changes

Assignees
No one assigned
Labels
deploy examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inconsistent crd name between examples dir and deploy dir
3 participants
@lbbniu @chenkaiyue @qmhu