update nginx.conf #678
Merged
update nginx.conf #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay encounter CORS error when using dashboard to manage multi clusters
|
@GoneLikeAir Tested in local by quick start (https://gocrane.io/docs/getting-started/quick-start/), it's not work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only add CORS header to grafana section in nginx.conf, otherwise it may encounter CORS error when using dashboard to manage multi clusters.
What type of PR is this?
Update nginx.conf
What this PR does / why we need it:
When using dashboard to manage multi clusters, if using the old nginx config will encounter CORS failure when accessing '/api/v1/recommendation' and other URLs, except those relative about grafana.
In #551 , @lbbniu delete CORS header from global section. But in this case, it will enconter CORS error when accessing grafana urls.
So, the solution is delete 'add_header Access-Control-Allow-Origin' from global section, and add it to grafana section:
Which issue(s) this PR fixes:
Fixes #551