Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strategic merge patch extend-resource for node status #869

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

michaelcheungdk
Copy link
Contributor

What type of PR is this?

Feature

What this PR does / why we need it:

Finished TODO,update NodeStatus by using StrategicMergePatch

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-10-22 22:23
Git Version: 2b35531

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-869-2b35531 docker pull gocrane/crane-agent:pr-869-2b35531
dashboard:pr-869-2b35531 docker pull gocrane/dashboard:pr-869-2b35531
metric-adapter:pr-869-2b35531 docker pull gocrane/metric-adapter:pr-869-2b35531
craned:pr-869-2b35531 docker pull gocrane/craned:pr-869-2b35531

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-869-2b35531 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-869-2b35531 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-869-2b35531 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-869-2b35531 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-869-2b35531 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-869-2b35531
dashboard:pr-869-2b35531 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-869-2b35531
metric-adapter:pr-869-2b35531 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-869-2b35531
craned:pr-869-2b35531 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-869-2b35531

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-869-2b35531 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-869-2b35531 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-869-2b35531 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-869-2b35531 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-869-2b35531 docker pull ghcr.io/gocrane/crane/crane-agent:pr-869-2b35531
dashboard:pr-869-2b35531 docker pull ghcr.io/gocrane/crane/dashboard:pr-869-2b35531
metric-adapter:pr-869-2b35531 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-869-2b35531
craned:pr-869-2b35531 docker pull ghcr.io/gocrane/crane/craned:pr-869-2b35531

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-869-2b35531 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-869-2b35531 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-869-2b35531 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-869-2b35531 crane/crane

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 13, 2023
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 22, 2023
@qmhu qmhu merged commit 34ad4a4 into gocrane:main Oct 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants