CI: Fix E2E job not finding WP-CLI binary #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrtashjian
added
[Type] Bug
jrtashjian
requested review from
AnthonyLedesma,
EvanHerman and
richtabor
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolved an issue where our end-to-end tests were not running because it couldn't find the WP-CLI binary. We were using a relative path to the binary in composer's vendor directory which was incorrect given the current working directory was set by
pathin the step.This PR also moves away from our
wp_creds.jsonfile and instead utilizescypress.env.jsonand theCypress.env()method. This solves the problems we have been having with overriding our local site config for Cypress on different environments.