Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gallery placeholder UX across blocks #1730

Merged
merged 3 commits into from Oct 13, 2020
Merged

Fix Gallery placeholder UX across blocks #1730

merged 3 commits into from Oct 13, 2020

Conversation

AnthonyLedesma
Copy link
Member

Description

This PR introduces SCSS fixes to allow for a proper UX with the media placeholder.

Screenshots

image
image
image
image

Types of changes

SCSS changes.

How has this been tested?

Tested manually within the editor.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma added the [Status] Needs Review Tracking pull requests that need another set of eyes label Oct 13, 2020
@AnthonyLedesma AnthonyLedesma self-assigned this Oct 13, 2020
@AnthonyLedesma AnthonyLedesma marked this pull request as ready for review October 13, 2020 14:18
@richtabor richtabor requested review from richtabor and removed request for jrtashjian and EvanHerman October 13, 2020 16:50
richtabor
richtabor approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richtabor richtabor merged commit 9eb5c5f into master Oct 13, 2020
@richtabor richtabor deleted the fix/gallery-placeholder branch October 13, 2020 16:51
@richtabor richtabor added this to the Next Release milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richtabor richtabor richtabor approved these changes

Assignees

@AnthonyLedesma AnthonyLedesma

Labels
[Status] Needs Review Tracking pull requests that need another set of eyes
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AnthonyLedesma @richtabor