WPEX-1512 set default color for social profiles with masked style and no social colors set #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snovosel
requested review from
AnthonyLedesma,
EvanHerman and
jrtashjian
as code owners
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
AnthonyLedesma
requested changes
Oct 4, 2021
There was a problem hiding this comment.
I am not able to replicate the reported issue. On my end, existing CSS styles handle this fallback color just fine.
coblocks/src/blocks/share/styles/style.scss
Lines 190 to 192 in 448bca2
|
@AnthonyLedesma it seems that this bug is not reproducible with the Go theme active. I was able to reproduce this using Twenty Twenty-One theme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the masked style and no social colors selected for the Social Profiles block, the icons were no longer visible. This PR sets a default color to black in the event that no color has been set.
Screenshots
Before:
https://user-images.githubusercontent.com/18115694/135293063-04edba73-35cf-4d3a-ad8b-6d8611819e49.mov
After:
https://user-images.githubusercontent.com/18115694/135293636-1ee915de-cd9c-4375-8f71-910c3025e3a7.mov
Types of changes
Bug fix
How has this been tested?
visually
Checklist: