Refactor DimensionsControl to functional component #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlemay-godaddy
requested review from
AnthonyLedesma,
EvanHerman,
jonathanbardo,
jrtashjian and
olafleur-godaddy
as code owners
jlemay-godaddy
commented
Oct 15, 2021
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
I suspect this will impact all blocks that use this control. I wonder what the deprecation impact of this change will be. |
|
I was just glancing at the performance deltas for this PR and they look really good 🚀
|
jonathanbardo
changed the title
olafleur-godaddy
approved these changes
Oct 25, 2021
jonathanbardo
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor DimensionsControl to fucntional component
Major code refactor to stop having ifs between padding and margin types
Use useDispatch instead of dispatch
Types of changes
Code refactoring
How has this been tested?
Manually testes
Checklist: