Fix Click to Tweet Font-Size controls and refactor to v2 #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download coblocks.zip: https://44370-128991767-gh.circle-artifacts.com/0/tmp/artifacts/coblocks-2268.zip |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Performance Test Results:
|
AnthonyLedesma
changed the title
AnthonyLedesma
requested review from
EvanHerman,
jonathanbardo,
jrtashjian and
olafleur-godaddy
as code owners
AnthonyLedesma
requested review from
olafleur
and removed request for
jrtashjian,
jonathanbardo,
EvanHerman and
olafleur-godaddy
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable sort-keys */ | |||
There was a problem hiding this comment.
why do you disable the sort-keys and then sort them anyway?
There was a problem hiding this comment.
why do you disable the sort-keys and then sort them anyway?
This gave me a good laugh! Thank you for calling me out here. I think what I did was sort a few of them realize that the file also wanted me to sort all the old deprecations.
olafleur-godaddy
approved these changes
Feb 8, 2022
jrtashjian
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Click to Tweet block V2 API change.
This change opts the block into
fontSizecontrols provided byblockSupportsin theblock.jsonfile.Deprecating from old fontSize controls are not working as expected. For whatever reason, the attributes will not migrate into the new object format and instead, we are forced to replace the block in the editor. Deprecated blocks come in with old attributes and are not correctly migrating attributes to new properties defined in the deprecated migration function.
Here are the attempted
isEligibleandmigratefunctions that were attempted and should work but do not properly transform the attributes to the new style.isEligible
migrate
Because blocks do not properly deprecate attributes into new attribute format we are forced to hack around the deprecation mechanism by replacing the block in the editor with the new style (or updating attributes to the new style manually).
This fix is similar to that of the Masonry block where attributes are not properly migrated and we are forced to replace the block with the correct attribute format.
Screenshots
Types of changes
JavaScript
How has this been tested?
Tested manually using old block markup.
Old Markup - v1
Old Markup - v1
Checklist: