Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try Highlight block V2 with Supports #2287

Merged
merged 6 commits into from Feb 23, 2022
Merged

Try Highlight block V2 with Supports #2287

merged 6 commits into from Feb 23, 2022

Conversation

AnthonyLedesma
Copy link
Member

Description

Move Highlight block to v2 API and opt-in to block supports for fontSize controls and color controls.

Screenshots

N/A Looks identical.

Types of changes

Minor changes here mostly removing code.
Uses the force-deprecate extension to migrate color and fontSize attributes to the new paradigm.

How has this been tested?

E2E and Jest tests are added.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma self-assigned this Feb 22, 2022
@godaddy-wordpress-bot
Copy link
Contributor

godaddy-wordpress-bot commented Feb 22, 2022 •
edited

Performance Test Results:

index master try-highlight-v2 change %
focus 105.42 121.62 15.37%
inserterHover 29.69 35.11 18.26%
inserterOpen 110.84 116.69 5.28%
inserterSearch 67.45 110.62 64%
load 22936.3 23406.2 2.05%
maxFocus 215.82 223.49 3.55%
maxInserterHover 35.36 43.19 22.14%
maxInserterOpen 479.61 468.51 -2.31%
maxInserterSearch 121.7 185.51 52.43%
maxType 73.68 73.4 -0.38%
minFocus 85.62 96.6 12.82%
minInserterHover 25.94 31.26 20.51%
minInserterOpen 64.59 70.51 9.17%
minInserterSearch 49.48 50.3 1.66%
minType 33.31 36.94 10.9%
type 39.97 44.88 12.28%

@cypress
Copy link

cypress bot commented Feb 22, 2022 •
edited


Test summary

368 • 30 • 2 • 2

Run details
Project CoBlocks
Status Failed
Commit f772225
Started Feb 23, 2022 4:23 PM
Ended Feb 23, 2022 4:30 PM
Duration 07:09 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️

Failures

Run group: e2e-chrome-wp-latest (Linux, Chrome )
extensions/colors/test/settings-modal-control.cypress.js 2 Failed
1 Settings Modal: Colors feature > can turn off all color settings
2 Settings Modal: Colors feature > can turn off custom color settings
blocks/dynamic-separator/test/dynamic-separator.cypress.js 1 Failed
1 Test CoBlocks Dynamic Seperator Block > Test dynamic separator colors.
blocks/form/test/form.cypress.js 1 Failed
1 Test CoBlocks Form Block > Test that color values are able to set and save.
blocks/icon/test/icon.cypress.js 1 Failed
1 Test CoBlocks Icon Block > Test the icon block color settings.
blocks/features/test/features.cypress.js 1 Failed
1 Test CoBlocks Features Block > Test features block saves with content values set.
blocks/hero/test/hero.cypress.js 1 Failed
1 Test CoBlocks Hero Block > Test hero block saves with color values set.
blocks/row/test/row.cypress.js 1 Failed
1 Test CoBlocks Row Block > Test row block saves with color values set.
blocks/accordion/test/accordion.cypress.js 1 Failed
1 Block: Accordion > can apply color settings
blocks/pricing-table/pricing-table-item/test/pricing-table-item.cypress.js 1 Failed
1 Test CoBlocks Pricing Table Item Block > Test pricing-table block saves with content values set.
This comment includes only the first 10 test failures. See all 15 failures in the Cypress Dashboard.
Run group: e2e-firefox-wp-latest (Linux, Firefox )
extensions/colors/test/settings-modal-control.cypress.js 2 Failed
1 Settings Modal: Colors feature > can turn off all color settings
2 Settings Modal: Colors feature > can turn off custom color settings
blocks/dynamic-separator/test/dynamic-separator.cypress.js 1 Failed
1 Test CoBlocks Dynamic Seperator Block > Test dynamic separator colors.
blocks/form/test/form.cypress.js 1 Failed
1 Test CoBlocks Form Block > Test that color values are able to set and save.
blocks/icon/test/icon.cypress.js 1 Failed
1 Test CoBlocks Icon Block > Test the icon block color settings.
blocks/features/test/features.cypress.js 1 Failed
1 Test CoBlocks Features Block > Test features block saves with content values set.
blocks/hero/test/hero.cypress.js 1 Failed
1 Test CoBlocks Hero Block > Test hero block saves with color values set.
blocks/row/test/row.cypress.js 1 Failed
1 Test CoBlocks Row Block > Test row block saves with color values set.
blocks/accordion/test/accordion.cypress.js 1 Failed
1 Block: Accordion > can apply color settings
blocks/pricing-table/pricing-table-item/test/pricing-table-item.cypress.js 1 Failed
1 Test CoBlocks Pricing Table Item Block > Test pricing-table block saves with content values set.
This comment includes only the first 10 test failures. See all 15 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@godaddy-wordpress-bot
Copy link
Contributor

godaddy-wordpress-bot commented Feb 22, 2022 •
edited

Download coblocks.zip: https://46252-128991767-gh.circle-artifacts.com/0/tmp/artifacts/coblocks-2287.zip

@godaddy-wordpress-bot
Copy link
Contributor

Code Coverage: 96.64% 💚

🗂 Folder Coverage 
src/blocks/accordion/                          100.00% ✅
src/blocks/accordion/accordion-item/           100.00% ✅
src/blocks/alert/                              100.00% ✅
src/blocks/author/                             100.00% ✅
src/blocks/buttons/                            100.00% ✅
src/blocks/click-to-tweet/                     100.00% ✅
src/blocks/counter/                            100.00% ✅
src/blocks/dynamic-separator/                  100.00% ✅
src/blocks/events/                              96.43% 💚
src/blocks/events/event-item/                  100.00% ✅
src/blocks/faq/                                100.00% ✅
src/blocks/faq/faq-item/                       100.00% ✅
src/blocks/features/                           100.00% ✅
src/blocks/features/feature/                   100.00% ✅
src/blocks/food-and-drinks/                    100.00% ✅
src/blocks/food-and-drinks/food-item/          100.00% ✅
src/blocks/form/fields/checkbox/               100.00% ✅
src/blocks/form/fields/date/                   100.00% ✅
src/blocks/form/fields/hidden/                 100.00% ✅
src/blocks/form/fields/name/                   100.00% ✅
src/blocks/form/fields/phone/                  100.00% ✅
src/blocks/form/fields/radio/                  100.00% ✅
src/blocks/form/fields/select/                 100.00% ✅
src/blocks/form/fields/text/                   100.00% ✅
src/blocks/form/fields/textarea/               100.00% ✅
src/blocks/form/fields/website/                100.00% ✅
src/blocks/gallery-carousel/                    96.43% 💚
src/blocks/gallery-collage/                    100.00% ✅
src/blocks/gallery-masonry/                     79.77% 💛
src/blocks/gallery-offset/                     100.00% ✅
src/blocks/gallery-stacked/                    100.00% ✅
src/blocks/gif/                                100.00% ✅
src/blocks/gist/                               100.00% ✅
src/blocks/hero/                                92.56% 💚
src/blocks/highlight/                          100.00% ✅
src/blocks/logos/                              100.00% ✅
src/blocks/map/                                100.00% ✅
src/blocks/media-card/                         100.00% ✅
src/blocks/opentable/                          100.00% ✅
src/blocks/post-carousel/                      100.00% ✅
src/blocks/posts/                              100.00% ✅
src/blocks/pricing-table/                      100.00% ✅
src/blocks/pricing-table/pricing-table-item/   100.00% ✅
src/blocks/row/                                 94.43% 💚
src/blocks/row/column/                          88.54% 💚
src/blocks/services/                           100.00% ✅
src/blocks/services/service/                   100.00% ✅
src/blocks/shape-divider/                      100.00% ✅
src/blocks/share/                               81.25% 💚
src/blocks/social-profiles/                     79.64% 💛
src/blocks/testimonials/                        87.50% 💚
src/blocks/testimonials/testimonial/           100.00% ✅

From Circle CI build 46029

@godaddy-wordpress-bot
Copy link
Contributor

Code Coverage: 96.64% 💚

🗂 Folder Coverage 
src/blocks/accordion/                          100.00% ✅
src/blocks/accordion/accordion-item/           100.00% ✅
src/blocks/alert/                              100.00% ✅
src/blocks/author/                             100.00% ✅
src/blocks/buttons/                            100.00% ✅
src/blocks/click-to-tweet/                     100.00% ✅
src/blocks/counter/                            100.00% ✅
src/blocks/dynamic-separator/                  100.00% ✅
src/blocks/events/                              96.43% 💚
src/blocks/events/event-item/                  100.00% ✅
src/blocks/faq/                                100.00% ✅
src/blocks/faq/faq-item/                       100.00% ✅
src/blocks/features/                           100.00% ✅
src/blocks/features/feature/                   100.00% ✅
src/blocks/food-and-drinks/                    100.00% ✅
src/blocks/food-and-drinks/food-item/          100.00% ✅
src/blocks/form/fields/checkbox/               100.00% ✅
src/blocks/form/fields/date/                   100.00% ✅
src/blocks/form/fields/hidden/                 100.00% ✅
src/blocks/form/fields/name/                   100.00% ✅
src/blocks/form/fields/phone/                  100.00% ✅
src/blocks/form/fields/radio/                  100.00% ✅
src/blocks/form/fields/select/                 100.00% ✅
src/blocks/form/fields/text/                   100.00% ✅
src/blocks/form/fields/textarea/               100.00% ✅
src/blocks/form/fields/website/                100.00% ✅
src/blocks/gallery-carousel/                    96.43% 💚
src/blocks/gallery-collage/                    100.00% ✅
src/blocks/gallery-masonry/                     79.77% 💛
src/blocks/gallery-offset/                     100.00% ✅
src/blocks/gallery-stacked/                    100.00% ✅
src/blocks/gif/                                100.00% ✅
src/blocks/gist/                               100.00% ✅
src/blocks/hero/                                92.56% 💚
src/blocks/highlight/                          100.00% ✅
src/blocks/logos/                              100.00% ✅
src/blocks/map/                                100.00% ✅
src/blocks/media-card/                         100.00% ✅
src/blocks/opentable/                          100.00% ✅
src/blocks/post-carousel/                      100.00% ✅
src/blocks/posts/                              100.00% ✅
src/blocks/pricing-table/                      100.00% ✅
src/blocks/pricing-table/pricing-table-item/   100.00% ✅
src/blocks/row/                                 94.43% 💚
src/blocks/row/column/                          88.54% 💚
src/blocks/services/                           100.00% ✅
src/blocks/services/service/                   100.00% ✅
src/blocks/shape-divider/                      100.00% ✅
src/blocks/share/                               81.25% 💚
src/blocks/social-profiles/                     79.64% 💛
src/blocks/testimonials/                        87.50% 💚
src/blocks/testimonials/testimonial/           100.00% ✅

From Circle CI build 46152

@godaddy-wordpress-bot
Copy link
Contributor

Code Coverage: 96.65% 💚

🗂 Folder Coverage 
src/blocks/accordion/                          100.00% ✅
src/blocks/accordion/accordion-item/           100.00% ✅
src/blocks/alert/                              100.00% ✅
src/blocks/author/                             100.00% ✅
src/blocks/buttons/                            100.00% ✅
src/blocks/click-to-tweet/                     100.00% ✅
src/blocks/counter/                            100.00% ✅
src/blocks/dynamic-separator/                  100.00% ✅
src/blocks/events/                              96.43% 💚
src/blocks/events/event-item/                  100.00% ✅
src/blocks/faq/                                100.00% ✅
src/blocks/faq/faq-item/                       100.00% ✅
src/blocks/features/                           100.00% ✅
src/blocks/features/feature/                   100.00% ✅
src/blocks/food-and-drinks/                    100.00% ✅
src/blocks/food-and-drinks/food-item/          100.00% ✅
src/blocks/form/fields/checkbox/               100.00% ✅
src/blocks/form/fields/date/                   100.00% ✅
src/blocks/form/fields/hidden/                 100.00% ✅
src/blocks/form/fields/name/                   100.00% ✅
src/blocks/form/fields/phone/                  100.00% ✅
src/blocks/form/fields/radio/                  100.00% ✅
src/blocks/form/fields/select/                 100.00% ✅
src/blocks/form/fields/text/                   100.00% ✅
src/blocks/form/fields/textarea/               100.00% ✅
src/blocks/form/fields/website/                100.00% ✅
src/blocks/gallery-carousel/                    96.43% 💚
src/blocks/gallery-collage/                    100.00% ✅
src/blocks/gallery-masonry/                     80.10% 💚
src/blocks/gallery-offset/                     100.00% ✅
src/blocks/gallery-stacked/                    100.00% ✅
src/blocks/gif/                                100.00% ✅
src/blocks/gist/                               100.00% ✅
src/blocks/hero/                                92.56% 💚
src/blocks/highlight/                          100.00% ✅
src/blocks/logos/                              100.00% ✅
src/blocks/map/                                100.00% ✅
src/blocks/media-card/                         100.00% ✅
src/blocks/opentable/                          100.00% ✅
src/blocks/post-carousel/                      100.00% ✅
src/blocks/posts/                              100.00% ✅
src/blocks/pricing-table/                      100.00% ✅
src/blocks/pricing-table/pricing-table-item/   100.00% ✅
src/blocks/row/                                 94.43% 💚
src/blocks/row/column/                          88.54% 💚
src/blocks/services/                           100.00% ✅
src/blocks/services/service/                   100.00% ✅
src/blocks/shape-divider/                      100.00% ✅
src/blocks/share/                               81.25% 💚
src/blocks/social-profiles/                     79.64% 💛
src/blocks/testimonials/                        87.50% 💚
src/blocks/testimonials/testimonial/           100.00% ✅

From Circle CI build 46260

@AnthonyLedesma
Copy link
Member Author

AnthonyLedesma commented Feb 23, 2022 •
edited

Only failing tests are related to the Color controls compat fix for WP 5.9.1

@AnthonyLedesma
Copy link
Member Author

Sorry for the confusing changes to the Stacked block here. Those were made to satisfy Linting complaints on those files after I merged with the main branch.

olafleur-godaddy
olafleur-godaddy approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@olafleur-godaddy olafleur-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Looks great to me!

@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Feb 23, 2022
@AnthonyLedesma AnthonyLedesma merged commit c0ad4b3 into master Feb 23, 2022
@AnthonyLedesma AnthonyLedesma deleted the try-highlight-v2 branch February 23, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafleur-godaddy olafleur-godaddy olafleur-godaddy approved these changes

@jrtashjian jrtashjian Awaiting requested review from jrtashjian

@EvanHerman EvanHerman Awaiting requested review from EvanHerman

@jonathanbardo jonathanbardo Awaiting requested review from jonathanbardo

Assignees

@AnthonyLedesma AnthonyLedesma

Labels
None yet
Projects
None yet
Milestone
2.22.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AnthonyLedesma @godaddy-wordpress-bot @olafleur-godaddy