Allow only images when uploading to the Services and Food & drink blocks #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafleur-godaddy
requested review from
jrtashjian,
EvanHerman,
AnthonyLedesma and
jonathanbardo
as code owners
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Performance Test Results:
|
| @@ -221,12 +221,13 @@ const FoodItem = ( props ) => { | |||
| return ( | |||
| <div className="wp-block-coblocks-food-item__figure"> | |||
| <MediaPlaceholder | |||
| accept={ 'image/*' } | |||
There was a problem hiding this comment.
This is the first line change
| @@ -170,14 +175,15 @@ const Edit = ( props ) => { | |||
| const renderPlaceholder = () => { | |||
| return ( | |||
| <MediaPlaceholder | |||
| className="wp-block-coblocks-service__figure" | |||
| accept={ 'image/*' } | |||
There was a problem hiding this comment.
This is the second line change
EvanHerman
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a filter to make sure that the user can only select images to upload.
Without linting, it's basically a two lines change (I've commented on them to show them)
Types of changes
Enhancement.
Screenshot
Only the images are allowed to be selected now.