Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPEX-1661 - add preview for event and event-item #2297

Merged
merged 1 commit into from Mar 9, 2022
Merged

Conversation

snovosel
Copy link
Contributor

@snovosel snovosel commented Mar 1, 2022

Description

This PR adds a preview to the event and event-item blocks

Screenshots

Types of changes

Bug fix / enhancement

How has this been tested?

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@snovosel snovosel self-assigned this Mar 1, 2022
@snovosel snovosel added [Status] Needs Review Tracking pull requests that need another set of eyes [Type] Bug Something that is not working as expected labels Mar 1, 2022
@godaddy-wordpress-bot
Copy link
Contributor

@cypress
Copy link

cypress bot commented Mar 1, 2022



Test summary

404 0 2 0


Run details

Project CoBlocks
Status Passed
Commit 6f1f4af
Started Mar 1, 2022 8:48 PM
Ended Mar 1, 2022 8:52 PM
Duration 04:09 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@godaddy-wordpress-bot
Copy link
Contributor

Performance Test Results:

index master WPEX-1661 change %
focus 121.52 131.03 7.83%
inserterHover 39.51 36.52 -7.57%
inserterOpen 135.92 113.53 -16.47%
inserterSearch 84.28 81.92 -2.8%
load 27275.6 23268.4 -14.69%
maxFocus 173.74 203.77 17.28%
maxInserterHover 52.9 69.83 32%
maxInserterOpen 593.37 484.64 -18.32%
maxInserterSearch 217.7 126.76 -41.77%
maxType 81.24 111.46 37.2%
minFocus 102.7 111.69 8.75%
minInserterHover 30.61 29.13 -4.84%
minInserterOpen 71.35 68.53 -3.95%
minInserterSearch 52.68 49.51 -6.02%
minType 36.66 34.37 -6.25%
type 50.27 49.73 -1.07%

@godaddy-wordpress-bot
Copy link
Contributor

Code Coverage: 96.65% 💚

🗂 Folder Coverage
src/blocks/accordion/                          100.00% ✅
src/blocks/accordion/accordion-item/           100.00% ✅
src/blocks/alert/                              100.00% ✅
src/blocks/author/                             100.00% ✅
src/blocks/buttons/                            100.00% ✅
src/blocks/click-to-tweet/                     100.00% ✅
src/blocks/counter/                            100.00% ✅
src/blocks/dynamic-separator/                  100.00% ✅
src/blocks/events/                              96.43% 💚
src/blocks/events/event-item/                  100.00% ✅
src/blocks/faq/                                100.00% ✅
src/blocks/faq/faq-item/                       100.00% ✅
src/blocks/features/                           100.00% ✅
src/blocks/features/feature/                   100.00% ✅
src/blocks/food-and-drinks/                    100.00% ✅
src/blocks/food-and-drinks/food-item/          100.00% ✅
src/blocks/form/fields/checkbox/               100.00% ✅
src/blocks/form/fields/date/                   100.00% ✅
src/blocks/form/fields/hidden/                 100.00% ✅
src/blocks/form/fields/name/                   100.00% ✅
src/blocks/form/fields/phone/                  100.00% ✅
src/blocks/form/fields/radio/                  100.00% ✅
src/blocks/form/fields/select/                 100.00% ✅
src/blocks/form/fields/text/                   100.00% ✅
src/blocks/form/fields/textarea/               100.00% ✅
src/blocks/form/fields/website/                100.00% ✅
src/blocks/gallery-carousel/                    96.43% 💚
src/blocks/gallery-collage/                    100.00% ✅
src/blocks/gallery-masonry/                     80.10% 💚
src/blocks/gallery-offset/                     100.00% ✅
src/blocks/gallery-stacked/                    100.00% ✅
src/blocks/gif/                                100.00% ✅
src/blocks/gist/                               100.00% ✅
src/blocks/hero/                                92.56% 💚
src/blocks/highlight/                          100.00% ✅
src/blocks/logos/                              100.00% ✅
src/blocks/map/                                100.00% ✅
src/blocks/media-card/                         100.00% ✅
src/blocks/opentable/                          100.00% ✅
src/blocks/post-carousel/                      100.00% ✅
src/blocks/posts/                              100.00% ✅
src/blocks/pricing-table/                      100.00% ✅
src/blocks/pricing-table/pricing-table-item/   100.00% ✅
src/blocks/row/                                 94.43% 💚
src/blocks/row/column/                          88.54% 💚
src/blocks/services/                           100.00% ✅
src/blocks/services/service/                   100.00% ✅
src/blocks/shape-divider/                      100.00% ✅
src/blocks/share/                               81.25% 💚
src/blocks/social-profiles/                     79.64% 💛
src/blocks/testimonials/                        87.50% 💚
src/blocks/testimonials/testimonial/           100.00% ✅

From Circle CI build 46879

Copy link
Member

@olafleur-godaddy olafleur-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@olafleur-godaddy olafleur-godaddy merged commit a6a2feb into master Mar 9, 2022
@olafleur-godaddy olafleur-godaddy deleted the WPEX-1661 branch March 9, 2022 03:38
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review Tracking pull requests that need another set of eyes [Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants