Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak form block styles #2309

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Tweak form block styles #2309

merged 1 commit into from
Mar 9, 2022

Conversation

EvanHerman
Copy link
Contributor

@EvanHerman EvanHerman commented Mar 7, 2022

Description

Tweak the styles of the form block in the editor.

  • Unify spacing between form blocks (name, select, checkbox etc.).
  • Tweak * color in editor/frontend.
  • Tweak the way the * is generated in the editor, so it's properly appended to the end of the field label text.

Screenshots

image

Types of changes

Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Manually inspected the spacing in the editor/frontend.

Acceptance criteria

  • The spacing between email/phone fields and services fields is inconsistent. It should be inline with name and email fields.
  • The asterix (*) in the terms and condition section should be next to privacy policy. currently it is after AND.
  • There should be a period after privacy policy.
  • The fonts particularly in the services section and text field beneath the T&C section (I have read and agree to the terms and conditions and privacy policy.) don't match with Go theme fonts.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've added proper labels to this pull request

@EvanHerman EvanHerman added [Type] Enhancement Something new that adds functionality [Type] Design Issues/PRs related to improving design labels Mar 7, 2022
@EvanHerman EvanHerman added this to the Next Release milestone Mar 7, 2022
@EvanHerman EvanHerman self-assigned this Mar 7, 2022
@EvanHerman EvanHerman marked this pull request as draft March 7, 2022 20:45
@cypress
Copy link

cypress bot commented Mar 7, 2022



Test summary

404 0 2 0


Run details

Project CoBlocks
Status Passed
Commit 2f26755
Started Mar 7, 2022 8:45 PM
Ended Mar 7, 2022 8:50 PM
Duration 04:22 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@godaddy-wordpress-bot
Copy link
Contributor

Performance Test Results:

index master form-style-tweaks change %
focus 105.08 120.25 14.44%
inserterHover 36.27 37.23 2.65%
inserterOpen 117.54 128.67 9.47%
inserterSearch 89.83 78.88 -12.19%
load 23257.1 24002.5 3.21%
maxFocus 130 148.18 13.98%
maxInserterHover 44.21 51.15 15.7%
maxInserterOpen 474.33 555.68 17.15%
maxInserterSearch 190.04 144.47 -23.98%
maxType 99.63 73.37 -26.36%
minFocus 94.51 95.82 1.39%
minInserterHover 32.35 30.1 -6.96%
minInserterOpen 68.7 74.53 8.49%
minInserterSearch 50.14 58.52 16.71%
minType 35.39 37.12 4.89%
type 43.13 49.59 14.98%

@EvanHerman EvanHerman marked this pull request as ready for review March 9, 2022 16:55
@AnthonyLedesma AnthonyLedesma merged commit a6d3fff into master Mar 9, 2022
@AnthonyLedesma AnthonyLedesma deleted the form-style-tweaks branch March 9, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Design Issues/PRs related to improving design [Type] Enhancement Something new that adds functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants