Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint everything on CI #2311

Merged
merged 8 commits into from
Mar 14, 2022
Merged

Lint everything on CI #2311

merged 8 commits into from
Mar 14, 2022

Conversation

olafleur-godaddy
Copy link
Member

@olafleur-godaddy olafleur-godaddy commented Mar 8, 2022

Description

This PR remove the scoping on CSS, JS and PHP linting.

Each of those step will be a little bit longer, but anyway, these steps are executed in parallel with really longer steps (e2e, perf), so the total build time is not changed.

However it brings a benefit because it allow us to make sure that we do not accidentally break something (by updating dependencies, for example, which would not pick properly the scoping).

Types of changes

Improve developer experience.

How has this been tested?

CircleCI

Acceptance criteria

Linting is not scoped anymore.

Checklist:

  • My code is tested
  • My code has proper inline documentation
  • I've included developer documentation
  • I've added proper labels to this pull request

@olafleur-godaddy olafleur-godaddy added [Type] Enhancement Something new that adds functionality [Type] Tooling Relevant to project tooling labels Mar 8, 2022
.eslintrc.js Outdated Show resolved Hide resolved
@godaddy-wordpress-bot
Copy link
Contributor

Performance Test Results:

index master lint-everything-on-ci change %
focus 184.28 153.34 -16.79%
inserterHover 48.2 44.49 -7.7%
inserterOpen 174.2 132.5 -23.94%
inserterSearch 85.67 75.05 -12.4%
load 32718.7 27271.1 -16.65%
maxFocus 225.2 225.44 0.11%
maxInserterHover 64.97 58.35 -10.19%
maxInserterOpen 739.56 523.3 -29.24%
maxInserterSearch 117.45 87.53 -25.47%
maxType 118.58 120.81 1.88%
minFocus 152.23 129.18 -15.14%
minInserterHover 38.54 34.65 -10.09%
minInserterOpen 91.32 75.8 -17%
minInserterSearch 68.69 63.79 -7.13%
minType 47.64 41.28 -13.35%
type 70.25 57.51 -18.14%

@cypress
Copy link

cypress bot commented Mar 8, 2022



Test summary

404 0 2 0


Run details

Project CoBlocks
Status Passed
Commit a7704bb
Started Mar 14, 2022 3:19 PM
Ended Mar 14, 2022 3:24 PM
Duration 04:27 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@godaddy-wordpress-bot
Copy link
Contributor

@godaddy-wordpress-bot
Copy link
Contributor

Code Coverage: 96.65% 💚

🗂 Folder Coverage
src/blocks/accordion/                          100.00% ✅
src/blocks/accordion/accordion-item/           100.00% ✅
src/blocks/alert/                              100.00% ✅
src/blocks/author/                             100.00% ✅
src/blocks/buttons/                            100.00% ✅
src/blocks/click-to-tweet/                     100.00% ✅
src/blocks/counter/                            100.00% ✅
src/blocks/dynamic-separator/                  100.00% ✅
src/blocks/events/                              96.43% 💚
src/blocks/events/event-item/                  100.00% ✅
src/blocks/faq/                                100.00% ✅
src/blocks/faq/faq-item/                       100.00% ✅
src/blocks/features/                           100.00% ✅
src/blocks/features/feature/                   100.00% ✅
src/blocks/food-and-drinks/                    100.00% ✅
src/blocks/food-and-drinks/food-item/          100.00% ✅
src/blocks/form/fields/checkbox/               100.00% ✅
src/blocks/form/fields/date/                   100.00% ✅
src/blocks/form/fields/hidden/                 100.00% ✅
src/blocks/form/fields/name/                   100.00% ✅
src/blocks/form/fields/phone/                  100.00% ✅
src/blocks/form/fields/radio/                  100.00% ✅
src/blocks/form/fields/select/                 100.00% ✅
src/blocks/form/fields/text/                   100.00% ✅
src/blocks/form/fields/textarea/               100.00% ✅
src/blocks/form/fields/website/                100.00% ✅
src/blocks/gallery-carousel/                    96.43% 💚
src/blocks/gallery-collage/                    100.00% ✅
src/blocks/gallery-masonry/                     80.10% 💚
src/blocks/gallery-offset/                     100.00% ✅
src/blocks/gallery-stacked/                    100.00% ✅
src/blocks/gif/                                100.00% ✅
src/blocks/gist/                               100.00% ✅
src/blocks/hero/                                92.56% 💚
src/blocks/highlight/                          100.00% ✅
src/blocks/logos/                              100.00% ✅
src/blocks/map/                                100.00% ✅
src/blocks/media-card/                         100.00% ✅
src/blocks/opentable/                          100.00% ✅
src/blocks/post-carousel/                      100.00% ✅
src/blocks/posts/                              100.00% ✅
src/blocks/pricing-table/                      100.00% ✅
src/blocks/pricing-table/pricing-table-item/   100.00% ✅
src/blocks/row/                                 94.43% 💚
src/blocks/row/column/                          88.54% 💚
src/blocks/services/                           100.00% ✅
src/blocks/services/service/                   100.00% ✅
src/blocks/shape-divider/                      100.00% ✅
src/blocks/share/                               81.25% 💚
src/blocks/social-profiles/                     79.64% 💛
src/blocks/testimonials/                        87.50% 💚
src/blocks/testimonials/testimonial/           100.00% ✅

From Circle CI build 47947

@olafleur-godaddy olafleur-godaddy merged commit 6bad1e7 into master Mar 14, 2022
@olafleur-godaddy olafleur-godaddy deleted the lint-everything-on-ci branch March 14, 2022 15:33
@olafleur-godaddy olafleur-godaddy added this to the Next Release milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Something new that adds functionality [Type] Tooling Relevant to project tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants