enhance restore cache to also install missing deps #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLedesma
requested review from
jrtashjian,
EvanHerman and
jonathanbardo
as code owners
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Download coblocks.zip: https://47625-128991767-gh.circle-artifacts.com/0/tmp/artifacts/coblocks-2317.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Presently in CI the cache is not being updated because of the nature of read-only cache storage in Circle CI. This enhancement will ensure that any missing or superfluous dependencies are updated on the fly as part of the restore cache job.
This change requires having Node and Yarn pre-installed in the container before installation.
Types of changes
Minor Ci changes.
How has this been tested?
Tested in CI.
Acceptance criteria
This should ensure that
yarn installis run against the present package.json regardless of cache status.