Try new editorScript property in block.json #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLedesma
requested review from
jrtashjian,
EvanHerman,
jonathanbardo and
olafleur-godaddy
as code owners
EvanHerman
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is take-two at attempting to fix the WordPress.org plugin details page for CoBlocks.
The #Meta team in WordPress slack has identified that this block.json property is one that is required for block registration. Going to give a shot at specifying both paths and slugs to check if there is a difference.
Types of changes
Removing a previous modification here that adds a translation function.
How has this been tested?
This will need to be deployed in a versioned release in order to test this proposed fix.
Acceptance criteria
The AC should be resolving the issue with improper block names on the plugin details page. Unfortunately, we will need to test this by releasing a version of CoBlocks.