Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RichText controls in 6.2.2 and 6.3 #2545

Merged
merged 1 commit into from Aug 7, 2023

Conversation

AnthonyLedesma
Copy link
Member

Description

Rich text controls were not functional in 6.2.2 after changes were introduced in #2538.

Changes here allow for backward compatibility and also resolve 'selection state' bugs with the Rich Text controls. Now we can persist the text controls for the Rich Text captions as expected.

Screenshots

coolCaptionEdit

Types of changes

Backward compat.

How has this been tested?

Tested manually.

Acceptance criteria

Should resolve RichText issues in both 6.2.2 and 6.3.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma self-assigned this Aug 7, 2023
@AnthonyLedesma AnthonyLedesma changed the title Fix rich-text controls in 6.2.2 and 6.3 Fix RichRext controls in 6.2.2 and 6.3 Aug 7, 2023
@AnthonyLedesma AnthonyLedesma changed the title Fix RichRext controls in 6.2.2 and 6.3 Fix RichText controls in 6.2.2 and 6.3 Aug 7, 2023
@EvanHerman EvanHerman self-requested a review August 7, 2023 18:51
@EvanHerman EvanHerman added the [Type] Enhancement Something new that adds functionality label Aug 7, 2023
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end with 6.2.2 and 6.3! 👍

@AnthonyLedesma AnthonyLedesma merged commit f074b69 into master Aug 7, 2023
197 of 199 checks passed
@AnthonyLedesma AnthonyLedesma deleted the fix-rich-captions-back-compat branch August 7, 2023 20:44
@AnthonyLedesma AnthonyLedesma added this to the 3.1.0 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Something new that adds functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants