Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try PHP 8.3 compatibility #2600

Merged
merged 1 commit into from Mar 21, 2024
Merged

Try PHP 8.3 compatibility #2600

merged 1 commit into from Mar 21, 2024

Conversation

olafleur-godaddy
Copy link
Member

Description

Screenshots

Types of changes

How has this been tested?

Acceptance criteria

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@olafleur-godaddy olafleur-godaddy marked this pull request as ready for review March 21, 2024 15:56
@EvanHerman EvanHerman requested review from EvanHerman and removed request for eherman-godaddy March 21, 2024 17:09
EvanHerman
EvanHerman approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@EvanHerman EvanHerman merged commit aac6f69 into master Mar 21, 2024
42 checks passed
@EvanHerman EvanHerman deleted the php83-compatibility branch March 21, 2024 17:09
@AnthonyLedesma AnthonyLedesma added this to the Next Release milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHerman EvanHerman EvanHerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olafleur-godaddy @EvanHerman @AnthonyLedesma