Update headers and theme responsiveness #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EvanHerman What do you think would be the best way to handle this? |
@richtabor hmm...Can we determine it with JS on page load? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a hefty one that I started to clean up minor issues I found. Here's what's new:
I improved the header functionality to style the header variations using CSS only, making things much simpler throughout the header variation logic. This lays the foundation for easily extending the header in the future (i.e. adding social to the header, a call to action button, cart icon, etc), without having to tweak each of the header partials.
I improved the responsive nature of the theme, using fluid
vm's instead of hard snapping breakpoints for the vertical spacing between blocks. The breakpoints that do exist were also tweaks to resemble that of which CoBlocks uses (which is what Gutenberg uses) - to ensure fluid transitions by using same breakpoints.I cleaned up the markup associated with the header and greatly improved how it handles long menus, as well as it's responsive nature.
The mobile navigation component has been rewritten to work better on mobile and inherit custom styling choices from the Customizer.
Search now displays on each of the header variations, laying the groundwork for adding an option to turn off search within the Customizer.
Note:
While the search toggle is styled properly here, the new search bar that @jrtashjian is working on is not included in this PR. That should be completed before we do our next release.