Change copyright text and relevant tests to "Go by GoDaddy" #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehamwey
added
the
[Status] Needs Review
fjarrett-godaddy
added
the
[Status] Do Not Merge
EvanHerman
reviewed
Jun 16, 2021
| @@ -1127,7 +1127,7 @@ function get_default_copyright() { | |||
| * @param string $copyright The default text for copyright. | |||
| */ | |||
| /* translators: the theme author */ | |||
| return (string) apply_filters( 'go_default_copyright', get_bloginfo( 'name' ) ); | |||
| return (string) apply_filters( 'go_default_copyright', sprintf( esc_html__( 'Go by %s', 'go' ), 'GoDaddy' ) ); | |||
There was a problem hiding this comment.
@ehamwey I don't think we need to pass this string through esc_html__() since its just a helper method for retrieving the copyright text. Generally it should be sanitized on output, which we're doing in certain places around Go.
We can probably just stick to sprintf( __( 'Go by %s', 'go' ), 'GoDaddy' ).
Line 397 in ffd7675
Line 566 in ffd7675
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts changes in #481 to include GoDaddy copyright in footer, as well as updates tests to check for the proper text.