Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WooCommerce product colors when inside of 'has-secondary-background-color' block. #905

Merged
merged 1 commit into from Feb 16, 2024

Conversation

AnthonyLedesma
Copy link
Member

@AnthonyLedesma AnthonyLedesma commented Feb 15, 2024

Added some styles here to set the text color for the product titles and product price if the WooCommerce blocks are inside of a background colored block with has-secondary-background-color. In the shared styles for WooCommerce blocks, we set the text color for both titles and prices to match the secondary color.

In cases where they are already within a secondary color background, we default instead to the 'primary' color.
Before
image

After
Screenshot 2024-02-15 at 10 50 01 AM

@AnthonyLedesma AnthonyLedesma self-assigned this Feb 15, 2024
@mtashjianjr-godaddy mtashjianjr-godaddy merged commit 35beeac into master Feb 16, 2024
10 of 12 checks passed
@mtashjianjr-godaddy mtashjianjr-godaddy deleted the fix-wc-colors-with-secondary-background branch February 16, 2024 18:07
@EvanHerman EvanHerman added this to the 1.8.9 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants