Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default text in forms is not localized #17

Open
fjarrett opened this issue Sep 8, 2016 · 1 comment
Open

Default text in forms is not localized #17

fjarrett opened this issue Sep 8, 2016 · 1 comment
Labels

Comments

@fjarrett
Copy link
Member

fjarrett commented Sep 8, 2016

Ideally, the default text inside sign up forms should be translated on-the-fly.

screen shot 2016-09-08 at 2 58 55 am

@fjarrett fjarrett added the bug label Sep 8, 2016
@robertsky
Copy link
Contributor

@fjarrett I am a zh_CN PTE on translate.wordpress.org. I was processing your strings and and it came to my attention that translate.wordpress.org has thrown an error for this plugin.

To shed more light, the text domain needs to match your plugin slug on wordpress.org. See: How to Internationalize Your Plugin - Text Domain

This is the error that is thrown up by the system (can be seen in wordpress.org's slack):

Import of godaddy-email-marketing-sign-up-forms
Time: Sat, 11 Feb 2017 01:16:21 +0000, Development Log
Code for stable (godaddy-email-marketing-sign-up-forms/tags/1.2.0/) in process...
This plugin has a wrong text domain declaration in the file header:
./godaddy-email-marketing.php: * Text Domain: godaddy-email-marketing
Code for stable was processed.
Readme for stable (godaddy-email-marketing-sign-up-forms/tags/1.2.0/) in process...
The GlotPress projects were updated.
Result of the POT import: 3 new strings added, 0 updated, 0 fuzzied, and 0 obsoleted.
Readme for stable was processed.

I have created a pull request (#26) as well to reflect the required change. Please verify and accept the pull request when verified. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants