Fix incorrect no-shadow warnings for TS enums (#315)

* fix: bad no-shadow warnings for TS enums * chore: add changeset
godaddy · May 5, 2023 · c2e15c2 · c2e15c2
1 parent eade664
commit c2e15c2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/.changeset/witty-guests-laugh.md b/.changeset/witty-guests-laugh.md
@@ -0,0 +1,6 @@
+---
+"eslint-config-godaddy-react-typescript": patch
+"eslint-config-godaddy-typescript": patch
+---
+
+Fix incorrect no-shadow warnings for TS enums
diff --git a/packages/eslint-config-godaddy-react-typescript/index.js b/packages/eslint-config-godaddy-react-typescript/index.js
@@ -21,7 +21,11 @@ module.exports = {
             args: 'after-used',
             ignoreRestSiblings: false
           }
-        ]
+        ],
+        // Disable the base rule and enable TypeScript version to avoid incorrect reports
+        // See https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-shadow.md
+        'no-shadow': 'off',
+        '@typescript-eslint/no-shadow': 'warn'
       }
     },
     {

diff --git a/packages/eslint-config-godaddy-typescript/index.js b/packages/eslint-config-godaddy-typescript/index.js
@@ -20,7 +20,11 @@ module.exports = {
             args: 'after-used',
             ignoreRestSiblings: false
           }
-        ]
+        ],
+        // Disable the base rule and enable TypeScript version to avoid incorrect reports
+        // See https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-shadow.md
+        'no-shadow': 'off',
+        '@typescript-eslint/no-shadow': 'warn'
       }
     }
   ]