Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valid-jsdoc Rule Deprecated & Triple-Slash Directive Support #577

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

kbader-godaddy
Copy link
Contributor

Summary

ESLint has deprecated the valid-jsdoc rule and recommends using eslint-plugin-jsdoc instead.

https://eslint.org/blog/2018/11/jsdoc-end-of-life/
https://github.com/gajus/eslint-plugin-jsdoc

Also, I have updated the spaced-comment rule to support using typescript triple-slash directives in JS files.

https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html

Changelog

  • Replaced valid-jsdoc with eslint-plugin-jsdoc
  • Added support for ts triple-slash directives in js files

Test Plan

All existing tests pass.

@kbader-godaddy kbader-godaddy requested a review from a team as a code owner March 7, 2024 21:08
@kbader-godaddy kbader-godaddy merged commit b1763b9 into godaddy:main Mar 14, 2024
4 checks passed
@kbader-godaddy kbader-godaddy deleted the eol-jsdoc branch March 14, 2024 22:17
@kbader-godaddy kbader-godaddy restored the eol-jsdoc branch March 14, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants