-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request with no callback results in error #189
Comments
silasbw
pushed a commit
that referenced
this issue
Feb 11, 2018
Resolves #189 BREAKING CHANGE: This removes the (deprecated) `request`-like behavior of returning a stream when the caller omits a callback. Use `.getStream` (instead of `.get` without a callback) to get a stream.
silasbw
pushed a commit
that referenced
this issue
Feb 11, 2018
Resolves #189 BREAKING CHANGE: This removes the (deprecated) `request`-like behavior of returning a stream when the caller omits a callback. Use `.getStream` (instead of `.get` without a callback) to get a stream.
Thanks @JacobReynolds. I implemented support in #193. It should get merged and published with a new major version in a couple of days. |
silasbw
pushed a commit
that referenced
this issue
Feb 11, 2018
Resolves #189 BREAKING CHANGE: This removes the (deprecated) `request`-like behavior of returning a stream when the caller omits a callback. Use `.getStream` (instead of `.get` without a callback) to get a stream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following request will cause an error, because there is no callback defined:
Would it be possible to just add a check here to see if a callback exists?
The text was updated successfully, but these errors were encountered: