-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typings do not match current interface #249
Comments
Yeah, we need to add this and it's high on the priority list. If someone wants to help out, the high-level approach would be:
const SwaggerClient = require('./swagger-client');
module.export = class Client extends SwaggerClient {
constructor() {
super({ version: '1.7' });
}
}; |
Fixes issue godaddy#249
I am trying to use the bindings from a VSCode extension for OpenShift but did not manage to find the solution. Is this related to this one as well ? |
Yep -- do you have some time to help out :)? |
Yes no pb |
Still an issue in 5.3.1. |
I know, I'm sorry :( I have a half-baked branch that generates the bindings. It's not quite ready, and I keep telling myself "I'll do it this weekend". I'll see what I can do. I'll at least try to dust it off and push it up in case someone else wants to contribute to it or take it over. |
@silasbw I believe I read something about a typescript generator for the OpenAPISpec a while ago maybe that would be a direction investigate? Could possibly save you some time. EDIT: I don't have the time to look at this issue further unfortunately. |
It would, but it doesn't generate very "fluent" names for the API calls. The names basically end up being the Operation ID which are pretty unwieldy and don't map well to the kubernetes reference documentation. I discuss this more is https://godaddy.github.io/2018/04/10/an-intuitive-nodejs-client-for-the-kubernetes-api/. Qualitatively I like the API naming conventions that kubernetes-client uses (e.g., |
This is the first PR that begins to address #249
This is the first PR that begins to address #249
) This is the first PR that begins to address #249
BREAKING CHANGE: This replaces the 4.X declaration file. Fixes #249
…313) This is the first PR that begins to address godaddy/kubernetes-client#249
BREAKING CHANGE: This replaces the 4.X declaration file. Fixes godaddy/kubernetes-client#249
The Typecript index.d.ts does not reflect the 5.2.0 interface.
KubernetesClient.Client is missing.
The text was updated successfully, but these errors were encountered: