Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed promises problem with Typings. #253

Merged
merged 2 commits into from
May 16, 2018
Merged

Fixed promises problem with Typings. #253

merged 2 commits into from
May 16, 2018

Conversation

nagapavan
Copy link
Contributor

Fixes issue #249

@nagapavan
Copy link
Contributor Author

These changes are little different from #183
Please review and check-in.

@nagapavan
Copy link
Contributor Author

@silasbw Can you please review and merge this PR?

@NoChance777
Copy link
Contributor

+1 can't use 5.2.0 without appropriate typings

@silasbw
Copy link
Contributor

silasbw commented May 16, 2018

Sure, but we'll need #249 for the 5.X+ interface.

@silasbw silasbw merged commit 4fc1eb0 into godaddy:master May 16, 2018
@silasbw
Copy link
Contributor

silasbw commented May 16, 2018

Published to npm as version 5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gisenberg gisenberg gisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nagapavan @NoChance777 @silasbw @gisenberg