Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Configurable Aliases #418

Closed
lholmquist opened this issue Feb 21, 2019 · 1 comment
Closed

User Configurable Aliases #418

lholmquist opened this issue Feb 21, 2019 · 1 comment

Comments

@lholmquist
Copy link
Contributor

It didn't look like there was a way currently to pass an object to add more aliases.

Context: I created a rest client for Openshift, and i'm trying to make the code simpler. I've actually passed this library a openshift swagger doc, and things just worked!

Openshift has its own aliases for things, like bc for buildconfigs and is for ImageStreams.

Just taking a quick glance at the alias code, it doesn't look like it would be much work to pass something in and merge what is currently defined.

I'd be happy to submit a PR for it

lholmquist added a commit to lholmquist/kubernetes-client-1 that referenced this issue Mar 4, 2019
getNames is used to setup alias's for the client.  This would allow someone to specify their own aliases.  This relates to godaddy#418
silasbw pushed a commit that referenced this issue Mar 4, 2019
getNames is used to setup alias's for the client.  This would allow someone to specify their own aliases.  This relates to #418
@lholmquist
Copy link
Contributor Author

closing. part of #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant