Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

hashicorp vault #62

Closed
bitsofinfo opened this issue May 14, 2019 · 6 comments · Fixed by #198
Closed

hashicorp vault #62

bitsofinfo opened this issue May 14, 2019 · 6 comments · Fixed by #198
Labels
enhancement New feature or request

Comments

@bitsofinfo
Copy link

Could this in theory support Hashicorp Vault?

@silasbw
Copy link
Contributor

silasbw commented May 17, 2019

Yes it could! We'd love a PR to add support :)

@JacopoDaeli
Copy link
Contributor

@bitsofinfo would you like to do a PR to add support for Vault?

@bitsofinfo
Copy link
Author

I don't have the time currently, was just curious if it would be possible

@bboerst
Copy link

bboerst commented May 23, 2019

Been working on this over here: https://github.com/tunein/kubernetes-external-secrets/tree/vault-backend
Let me know if you want me to open up a PR to get some more eyes looking at this. It's working but I'm sure some optimizations can be made.

@JacopoDaeli JacopoDaeli added the enhancement New feature or request label May 30, 2019
@cmacrae
Copy link

cmacrae commented Jul 11, 2019

Nice work @bboerst 👏 I think it'd be great to get this opened as an MR to get some traction and get people reviewing. Are there any particular points in your implementation you feel need extra scrutiny?
I've had a look over it, and it's looking good to me 👌

@jeffpearce
Copy link
Contributor

@bboerst please open a PR - we'd love to get this integrated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants