Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the tracing for individual query names inside a batch #49

Closed
wants to merge 1 commit into from

Conversation

enterline
Copy link

Currently all queries inside a batch are not being captured for metrics. This change will assemble a list of the individual query names inside the batch and call metric for each one using the same batch duration for each.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 987b21c on enterline:batch-trace into 75b6395 on godaddy:master.

@scommisso
Copy link
Contributor

My only concern here is that if you're gathering metrics on a particular method (say insert-entity) and now the entire batch time is attached to the individual requests within the batch, it'll give false positives on response time spikes if the batch size is variable.

Alternatively, you could add a queryName property to the batch, and then that will be tracked separately. I like automatically doing this, though, if the # queries in the batch happens to be 1.

@asilvas
Copy link
Contributor

asilvas commented Nov 22, 2019

close?

@scommisso
Copy link
Contributor

close?

I'm OK with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants