[fix] Handle Check Collaborator rejection properly

godaddy · Aug 7, 2019 · d9ea86d · d9ea86d
1 parent 18c7e1f
commit d9ea86d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 # CHANGELOG
 
+- [fix] Check Collaborator rejects on unknown users, so handle that appropriately
+
 ## 2.0.0-rc4
 
 - [fix] Handle case with no `.pullierc` file better

diff --git a/plugins/reviewers/index.js b/plugins/reviewers/index.js
@@ -204,13 +204,16 @@ class ReviewerPlugin {
     })));
 
     return await pReduce(maybeUsers, async (memo, user) => {
-      const res = await context.github.repos.checkCollaborator({
-        ...context.repo(),
-        username: user
-      });
-      const userExists = res.status === 204;
-
-      return userExists ? memo.concat([user]) : memo;
+      try {
+        const res = await context.github.repos.checkCollaborator({
+          ...context.repo(),
+          username: user
+        });
+
+        return res.status === 204 ? memo.concat([user]) : memo;
+      } catch (err) {
+        return memo;
+      }
     }, []);
   }
 }