Drop node 12 support, address review feedback

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.x]
+        node-version: [14.x, 16.x]
 
     steps:
     - uses: actions/checkout@v2

README.md

@@ -10,7 +10,7 @@ tickets, requesting reviews, and commenting about a missing required file change
 
 ## System requirements
 
-Pullie runs on public GitHub or on GitHub Enterprise 2.14 or later. It requires Node.js 12 or later.
+Pullie runs on public GitHub or on GitHub Enterprise 2.14 or later. It requires Node.js 14 or later.
 
 ## How to run/deploy
 

babel.config.cjs

@@ -1,9 +1,9 @@
 module.exports = {
-  "presets": [
-    ["@babel/preset-env", {
-      "targets": {
-        "node": "current"
+  presets: [
+    ['@babel/preset-env', {
+      targets: {
+        node: 'current'
       }
     }]
   ]
-}
+};

package.json

@@ -66,7 +66,7 @@
     "smee-client": "^1.2.2"
   },
   "engines": {
-    "node": ">= 12"
+    "node": ">= 14"
   },
   "nodemonConfig": {
     "exec": "npm start",

test/unit/config-processor.test.js

@@ -2,10 +2,10 @@ import assume from 'assume';
 import assumeSinon from 'assume-sinon';
 import sinon from 'sinon';
 
-assume.use(assumeSinon);
-
 import processConfig, { applyExcludeList, applyIncludeList } from '../../config-processor.js';
 
+assume.use(assumeSinon);
+
 /**
  * @typedef {Object} Plugin
  * @prop {string} plugin The name of the plugin

test/unit/plugins/welcome.test.js

@@ -7,8 +7,7 @@ assume.use(assumeSinon);
 import WelcomePlugin from '../../../plugins/welcome/index.js';
 import Commenter from '../../../commenter.js';
 
-const sandbox = sinon.createSandbox();
-const addCommentStub = sandbox.stub();
+const addCommentStub = sinon.stub();
 const commenter = {
   addComment: addCommentStub
 };
@@ -17,7 +16,7 @@ const welcomePlugin = new WelcomePlugin();
 
 describe('WelcomePlugin', function () {
   after(function () {
-    sandbox.restore();
+    sinon.restore();
   });
 
   let mockContext;