Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency url-parse to 1.5.9 [SECURITY] - autoclosed #113

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 18, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change
url-parse 1.5.7 -> 1.5.9

GitHub Vulnerability Alerts

CVE-2022-0686

url-parse prior to version 1.5.8 is vulnerable to Authorization Bypass Through User-Controlled Key.

CVE-2022-0691

Leading control characters in a URL are not stripped when passed into url-parse. This can cause input URLs to be mistakenly be interpreted as a relative URL without a hostname and protocol, while the WHATWG URL parser will trim control characters and treat it as an absolute URL.

If url-parse is used in security decisions involving the hostname / protocol, and the input URL is used in a client which uses the WHATWG URL parser, the decision may be incorrect.

This can also lead to a cross-site scripting (XSS) vulnerability if url-parse is used to check for the javascript: protocol in URLs. See following example:

const parse = require('url-parse')
const express = require('express')
const app = express()
const port = 3000

url = parse(\"\\bjavascript:alert(1)\")

console.log(url)

app.get('/', (req, res) => {
 if (url.protocol !== \"javascript:\") {res.send(\"<a href=\\'\" + url.href + \"\\'>CLICK ME!</a>\")}
 })

app.listen(port, () => {
 console.log(`Example app listening on port ${port}`)
 })

Configuration

πŸ“… Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@coveralls
Copy link

coveralls commented Feb 18, 2022

Pull Request Test Coverage Report for Build 2060448549

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2060440267: 0.0%
Covered Lines: 1132
Relevant Lines: 1132

πŸ’› - Coveralls

@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from ca10e68 to 95c2ddc Compare February 28, 2022 09:00
@renovate renovate bot changed the title Update dependency url-parse to 1.5.6 [SECURITY] Update dependency url-parse [SECURITY] Feb 28, 2022
@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from 95c2ddc to c2ff420 Compare March 4, 2022 02:43
@renovate renovate bot changed the title Update dependency url-parse [SECURITY] Update dependency url-parse to 1.5.9 [SECURITY] Mar 29, 2022
@renovate renovate bot force-pushed the renovate/npm-url-parse-vulnerability branch from c2ff420 to 90b2553 Compare March 29, 2022 18:37
@renovate renovate bot changed the title Update dependency url-parse to 1.5.9 [SECURITY] Update dependency url-parse to 1.5.9 [SECURITY] - autoclosed Mar 29, 2022
@renovate renovate bot closed this Mar 29, 2022
@renovate renovate bot deleted the renovate/npm-url-parse-vulnerability branch March 29, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants