Skip to content

Commit

Permalink
Fix busted container (#409)
Browse files Browse the repository at this point in the history
* Fix busted container

We were trying really hard to build with python 3.11 and getting a
busted result. Force build with python 3.10 and everything is easy --
and the result works.

* Revert "drop support for python36 (#400)"

This reverts commit 70e4667.

We need to defer this until after the 3.3.1 bugfix is released.

* version bump

Co-authored-by: Scott Bailey <scott.bailey@godaddy.com>
  • Loading branch information
rbailey-godaddy and rscottbailey committed Nov 23, 2022
1 parent 70e4667 commit 81115e0
Show file tree
Hide file tree
Showing 6 changed files with 132 additions and 73 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: [3.7, 3.8, 3.9, "3.10"]
python-version: [3.6, 3.7, 3.8, 3.9, "3.10"]
include:
- os: ubuntu-latest
path: ~/.cache/pypoetry
Expand All @@ -39,6 +39,7 @@ jobs:
name: Checkout the repo
- uses: actions/cache@c64c572235d810460d0d6876e9c705ad5002b353
name: Cache Poetry & Tox deps
if: ${{ !(matrix.os == 'windows-latest' && matrix.python-version == '3.6') }}
with:
path: |
{{ matrix.path }}
Expand Down
11 changes: 10 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
v3.3.1 - 23 Nov 2022
--------------------

Bug fixes:
* [#408](https://github.com/godaddy/tartufo/issues/408) - 3.3.0 container broken
* Rebuild container using python 3.10 base instead of python 3.11
* Eliminates reference to missing library present in 3.3.0 container
* Eliminates requirement for build-it-yerself libraries in container

v3.3.0 - 22 Nov 2022
----------------------
--------------------
Features:
* [#401](https://github.com/godaddy/tartufo/pull/401) - Add report output format

Expand Down
10 changes: 1 addition & 9 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3-slim as base
FROM python:3.10-slim as base

WORKDIR /app

Expand All @@ -9,14 +9,6 @@ ENV PIP_DEFAULT_TIMEOUT=100 \
PIP_NO_CACHE_DIR=1 \
POETRY_VERSION=1.1.12

RUN apt-get update && apt-get upgrade -y && apt-get install make cmake gcc libssl-dev wget -y
RUN wget https://github.com/libgit2/libgit2/archive/refs/tags/v1.4.0.tar.gz -O libgit2-1.4.0.tar.gz \
&& tar xzf libgit2-1.4.0.tar.gz \
&& cd libgit2-1.4.0/ \
&& cmake . \
&& make \
&& make install
RUN apt-get install libffi-dev -y
RUN pip --no-cache-dir install "poetry==$POETRY_VERSION"
RUN python -m venv /venv

Expand Down

0 comments on commit 81115e0

Please sign in to comment.