Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable regex scans by default #254 #271

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Conversation

mdayanc-GoDaddy
Copy link
Contributor

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

  • Tests (if applicable)
  • Documentation (if applicable)
  • Changelog entry
  • A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

  • Yes (backward compatible)
  • No (breaking changes)

Issue Linking

closes #254

What's new?

  • Changed the default value of "--regex/--no-regex", to True so that by default we have all scans and users can omit the ones they don't like

@mdayanc-GoDaddy mdayanc-GoDaddy requested a review from a team as a code owner November 5, 2021 17:56
@mdayanc-GoDaddy mdayanc-GoDaddy requested review from tarkatronic, janerikcarlsen and rbailey-godaddy and removed request for a team November 5, 2021 17:56
@mdayanc-GoDaddy mdayanc-GoDaddy changed the title Enable regex scans by default #254 #260 Enable regex scans by default #254 Nov 5, 2021
@tarkatronic tarkatronic linked an issue Nov 5, 2021 that may be closed by this pull request
@tarkatronic tarkatronic merged commit a1e3763 into godaddy:v3.x Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable regex scans by default
2 participants