Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better docker build #297

Merged
merged 5 commits into from Dec 10, 2021
Merged

Better docker build #297

merged 5 commits into from Dec 10, 2021

Conversation

tarkatronic
Copy link
Contributor

While our docker image was building now, it wasn't actually working, because installing libgit2-dev did not install libgit2. So now we both build the Docker image and test it in our CI pipeline.

@tarkatronic tarkatronic requested a review from a team as a code owner December 9, 2021 23:37
sushantmimani
sushantmimani approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@sushantmimani sushantmimani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦅

@sushantmimani sushantmimani merged commit c88cca1 into main Dec 10, 2021
@sushantmimani sushantmimani deleted the better-docker-build branch December 10, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushantmimani sushantmimani sushantmimani approved these changes

@jmink-godaddy jmink-godaddy Awaiting requested review from jmink-godaddy jmink-godaddy is a code owner automatically assigned from godaddy/tartufo

@emayuri-godaddy emayuri-godaddy Awaiting requested review from emayuri-godaddy emayuri-godaddy is a code owner automatically assigned from godaddy/tartufo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tarkatronic @sushantmimani