Upgrade pygit2 to allow version until <2.0 #330
Conversation
|
Unfortunately this is not a possible upgrade at the moment. We had to make the decision at the time to pin It would be great to drop Python 3.6 support, but that will require a major version bump (v4.0) which requires a lot harder consideration. One thing that has been discussed, but not yet experimented with, is that we might possibly be able to require different versions of |
Keep old pygit2 version pinned for python 3.6, but allow newer versions to use the current version (which supports 3.10). Add 3.10 to tox and CI version matrices.
|
I merged a commit that twiddles the dependency along the line @tarkatronic suggested, together with adding python 3.10 to the unit test matrices. My PC doesn't have fully-baked environments for all of these versions available, so we'll need to see what verdict is returned by the CI tests and then potentially do some followup triage. |
I was doing the multiple dependency change and when I pushed you havea lready done it 😅 Good job. And thanks. |
Thank me when it works. I am about to commit a further change to rebase the docker image onto 3-slim (Debian) instead of alpine, as this significantly simplifies the build and eliminates weird libgit2 dependencies (because we can install wheel packages). |
This switches from alpine to Debian. The old base had become unworkable because alpine ships only libgit 1.3.0, and pygit2 needs libgit 1.4.0. Debian is GLIBC-based, enabling the use of binary wheels, so pygit2 includes the necessary pre-built libraries and we no longer have dependencies on the OS-provided library.
| @@ -1,4 +1,4 @@ | |||
| FROM python:3-alpine3.14 as base | |||
| FROM python:3-slim as base | |||
There was a problem hiding this comment.
What is the resulting change in image size here?
There was a problem hiding this comment.
3-alpine3.14 is 45.2 MB; 3-slim is 122 MB -- the final image is 260 MB, which is noticeably larger than the 88.1 MB of the current alpine-based build from main.
On the other hand, it's not quite apples-to-apples because the current code (in this branch) can't be built on any existing version of alpine at all, because compilation requires newer versions of some libraries than anything shipped by alpine. We could potentially fudge this by backleveling versions (to less backleveled than they were) in hopes of finding some happy medium, but it just didn't seem worth it.
That was before I read https://pythonspeed.com/articles/base-image-python-docker-images/ yesterday. :)
Co-authored-by: Joey Wilhelm <tarkatronic@gmail.com>
Current
tartufoversion requires dependencypygit2<1.7, which depends onlibgit2v1.1.x(see https://github.com/libgit2/pygit2/blob/master/CHANGELOG.rst).Most recent operating systems packages include
libgit2v1.2 or newer (newest version is1.4.2), which would break the installation oftartufo.This PR updates
pygit2dependency to allow until version<2.0, which should be ok as no breaking changes have been added untilv1.9.To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Breaking change notice
pygit2v1.8.0introduces a breaking change by renamingRemoteCallbacks.progress()toRemoteCallbacks.sideband_progress(), but I didn't find any ocurrence of this function call in the source code.Issue Linking
What's new?
pygit2from versions1.6to1.9.x