Add --no-git-check option to skip confirmation dialog for scan-folder #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarkatronic
reviewed
Apr 8, 2022
tartufo/commands/scan_folder.py
Outdated
| is_flag=True, | ||
| default=True, | ||
| show_default=True, | ||
| help="Check if folder is a git repo and show confirmation dialog", |
There was a problem hiding this comment.
Since we're defaulting to True, do you think it makes more sense to change this help text to talking about disabling the check?
There was a problem hiding this comment.
I was following the pattern for the other option, but makes sense to change it - pushing a fix shortly.
tarkatronic
approved these changes
May 26, 2022
rbailey-godaddy
force-pushed
the
git_check
branch
from
ab555e8
to
248485f
Compare
rbailey-godaddy
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Issue Linking
What's new?
Add
--no-git-checkoption to skip confirmation dialog when usingscan-foldercommand. Useful when piping intojqto find the offenses in the current version of the files in git repo.