Update default_regexes.json to expand Password in URL detection #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afammartino-godaddy
requested review from
irodelta,
jmink-godaddy and
rbailey-godaddy
rbailey-godaddy
requested changes
Aug 8, 2022
Co-authored-by: Scott Bailey <72747501+rbailey-godaddy@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hey just wondering if anyone else had some thoughts on how to handle tests for these regex changes? |
afammartino-godaddy
requested review from
rbailey-godaddy
and removed request for
irodelta and
jmink-godaddy
rbailey-godaddy
approved these changes
Aug 15, 2022
sushantmimani
approved these changes
Aug 17, 2022
emayuri-godaddy
requested changes
Aug 17, 2022
Co-authored-by: Esha Mayuri <88688228+emayuri-godaddy@users.noreply.github.com>
rbailey-godaddy
approved these changes
Aug 29, 2022
emayuri-godaddy
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Issue Linking
#375
What's new?
Update the "Password in URL" default_regexes.json to allow for usernames/passwords of length 40 and remove the requirement of an fqdn/port/location/query_params of length less than 100.
Notes
I would like additional help/guidance on testing the performance impact of this change. I did some runtime testing and saw minimal increase in cpu time.