Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Terminus be used as an ExpressJS middleware? #292

Open
vorant94 opened this issue Aug 20, 2023 · 1 comment
Open

Can Terminus be used as an ExpressJS middleware? #292

vorant94 opened this issue Aug 20, 2023 · 1 comment

Comments

@vorant94
Copy link

Hi, there!

I found this great lib that helps organize health-check and graceful shutdowns boilerplate and it is doing pretty well, thanks for it!

The way that the lib is working for me is that I create ExpressJS app, than I create http.Server from the app and enrich the server with terminus. In my specific case I need to avoid converting the ExpressJS app into http.Server... Is there an option to use this lib as an ExpressJS middleware instead of enriching the http.Server?

@vorant94 vorant94 changed the title Can this lib be used as an ExpressJS middleware? Can Terminus be used as an ExpressJS middleware? Aug 20, 2023
@Falinor
Copy link

Falinor commented May 14, 2024

For the record, I do not think that terminus is usable as a middleware because it binds on the server’s event listeners, not on the request flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants