Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Update translations #185

Closed
EvanHerman opened this issue Mar 28, 2017 · 0 comments
Closed

Update translations #185

EvanHerman opened this issue Mar 28, 2017 · 0 comments

Comments

@EvanHerman
Copy link
Contributor

WPCS isn't a fan of our translation strings and is throwing an error.

https://travis-ci.org/godaddy/wp-primer-theme/jobs/216079486

We should update our strings to reflect the following format:

<?php
/* translators: %s: post title */
printf( esc_attr__( 'Continue reading %s', 'primer' ), get_the_title() ); 
?>

In a recent discussion with a core translator I was informed that _x functions are used for multiple instances of the same word(s) to add context.

Not sure how this approach would effect the current method of translating, but something that needs to be addressed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant