Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for array of arrays #82

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

timvancann
Copy link
Collaborator

The structure for an array of arrays as it is currently rendered is not supported by fastavro. This PR fixes this nested structure such that pydantic models with list of lists can be parsed into an avro schema correctly.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13 🎉

Comparison is base (705dc7c) 90.59% compared to head (70e83c7) 90.73%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   90.59%   90.73%   +0.13%     
==========================================
  Files           2        2              
  Lines         202      205       +3     
==========================================
+ Hits          183      186       +3     
  Misses         19       19              
Impacted Files Coverage Δ
src/pydantic_avro/base.py 98.03% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chidifrank chidifrank merged commit 43a0b44 into godatadriven:main Jul 20, 2023
10 checks passed
sharonyogev pushed a commit to sharonyogev/pydantic-avro that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants