Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #53 - Updates Carbon version to include fix for PHP 8.2 setLastError() #54

Merged
merged 1 commit into from Jan 25, 2023

Conversation

danstreeter
Copy link
Contributor

@danstreeter danstreeter commented Jan 19, 2023

PR to fix #53 as above... Tested on OSX Monterey on PHP 8.2.
Fix not required for PHP 8.0

@danstreeter danstreeter changed the title Fixes #53 - Updates Carbon version to include fix for 8.2 setLastError() Fixes #53 - Updates Carbon version to include fix for PHP 8.2 setLastError() Jan 19, 2023
@godbout
Copy link
Owner

godbout commented Jan 20, 2023

thanks. running the tests and i'll check out.

@godbout godbout merged commit 0780023 into godbout:master Jan 25, 2023
@godbout
Copy link
Owner

godbout commented Jan 25, 2023

tests fail because Everhour got rid of their APIs? can't find the API key anymore etc. contacted them. will see. rest should be ok so merged. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continue a time results in Uncaught TypeError: Carbon\Carbon::setLastErrors()
2 participants