fix: fix panic for Variant sign is 's' ,but value is (*string) not st… #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring fix panic for Variant sign is 's' ,but value is (*string) not string Log: fix panic for Variant sign is 's' ,but value is (*string) not string
|
Fair point that pointers within Variants aren't handled correctly here. I'm not sure how they could be useful, but if creating them is possible, then formatting should be possible as well of course. Can you add code to make this generic for all pointer types by using reflect, and not just specific for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ring
fix panic for Variant sign is 's' ,but value is (*string) not string
Log: fix panic for Variant sign is 's' ,but value is (*string) not string