Regression due to PR #77 #80
Comments
jsouthworth
added a commit
to jsouthworth/dbus
that referenced
this issue
Mar 3, 2017
The old algorithm iterated on the destination datastructures. This meant that tricky look ahead was required to handle all cases. By iterating on the source datastructure instead we can vastly simplify the logic for converting a source type into a destination type. This commit changes the type mismatch errors to indicate the actual problem with the types. Additional test cases now catch the problems seen by coreos/go-systemd. Fixes godbus#80
jsouthworth
added a commit
to jsouthworth/dbus
that referenced
this issue
Mar 3, 2017
The old algorithm iterated on the destination datastructures. This meant that tricky look ahead was required to handle all cases. By iterating on the source datastructure instead we can vastly simplify the logic for converting a source type into a destination type. This commit changes the type mismatch errors to indicate the actual problem with the types. Additional test cases now catch the problems seen by coreos/go-systemd. Fixes godbus#80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@lucab reports:
I haven't dug much further, but this PR seems to have induced a test regression in go-systemd: coreos/go-systemd#225 (comment).
The text was updated successfully, but these errors were encountered: