Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to uber zap logging #18

Closed
pcting opened this issue Oct 7, 2020 · 0 comments · Fixed by #19
Closed

switch to uber zap logging #18

pcting opened this issue Oct 7, 2020 · 0 comments · Fixed by #19
Assignees
@pcting
Labels
enhancement New feature or request
Projects
Improve API Friendliness
Milestone
v0.1

Comments

@pcting
Copy link
Contributor

pcting commented Oct 7, 2020

Is your feature request related to a problem? Please describe.
switch to https://github.com/uber-go/zap for logging

Describe the solution you'd like
logrus messages aren't showing up when panics happen.
@pcting pcting added the enhancement New feature or request label Oct 7, 2020
@pcting pcting added this to the 0.1 milestone Oct 7, 2020
@pcting pcting self-assigned this Oct 7, 2020
@pcting pcting added this to To do in Improve API Friendliness via automation Oct 7, 2020
pcting added a commit that referenced this issue Oct 8, 2020
@pcting
GH-18: zap logging
8a01278 
* Clean up code here and there
* Update vscode launch.json
pcting added a commit that referenced this issue Oct 8, 2020
@pcting
GH-18: zap logging
a434505 
* Clean up code here and there
* Update vscode launch.json
pcting added a commit that referenced this issue Oct 8, 2020
@pcting
GH-18: zap logging (#19)
11803eb 
* Clean up code here and there
* Update vscode launch.json
@pcting pcting linked a pull request Oct 8, 2020 that will close this issue
GH-18: zap logging #19
Merged
@pcting pcting closed this as completed Oct 8, 2020
Improve API Friendliness automation moved this from To do to Done Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcting pcting

Labels
enhancement New feature or request
Projects
No open projects
Improve API Friendliness
  
Done
Milestone
v0.1
Development

Successfully merging a pull request may close this issue.

GH-18: zap logging godot-go/godot-go
1 participant
@pcting